Skip to content
This repository was archived by the owner on Feb 18, 2020. It is now read-only.

Create CONTRIBUTING.md#423

Open
Velenir wants to merge 2 commits into
developfrom
DX-542/contributing_guide
Open

Create CONTRIBUTING.md#423
Velenir wants to merge 2 commits into
developfrom
DX-542/contributing_guide

Conversation

@Velenir

@Velenir Velenir commented Nov 8, 2018

Copy link
Copy Markdown
Contributor

Contributing guide for dx-react

@ghost

ghost commented Nov 8, 2018

Copy link
Copy Markdown

Travis automatic deployment:
https://pr423--dxreact.review.gnosisdev.com

1 similar comment
@ghost

ghost commented Nov 8, 2018

Copy link
Copy Markdown

Travis automatic deployment:
https://pr423--dxreact.review.gnosisdev.com

@W3stside W3stside left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dope

@W3stside

W3stside commented Nov 8, 2018

Copy link
Copy Markdown
Contributor

@Velenir I'd move the branch to develop

@Velenir

Velenir commented Nov 9, 2018

Copy link
Copy Markdown
Contributor Author

@W3stside
what matters is that doc/md files end up on master, like ADD_TOKEN_REQUEST_TEMPLATE.md was merged to master first

@W3stside W3stside changed the base branch from master to develop December 4, 2018 16:48
@ghost

ghost commented Dec 4, 2018

Copy link
Copy Markdown

Travis automatic deployment:
https://pr423--dxreact.review.gnosisdev.com

1 similar comment
@ghost

ghost commented Dec 4, 2018

Copy link
Copy Markdown

Travis automatic deployment:
https://pr423--dxreact.review.gnosisdev.com

@anxolin anxolin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Dima! I think we need this in every project :) can we you just add it as a low prio thing to do at some point. Thx!

@W3stside

W3stside commented Dec 5, 2018

Copy link
Copy Markdown
Contributor

@Velenir @anxolin can we not merge this already?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants