Skip to content

Watch a data link source with whatever the platform provides #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DTW-Thalion wants to merge 1 commit into
base: master
Choose a base branch
from
+390 −37
Open

Watch a data link source with whatever the platform provides #908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
2026-08-11 Todd White <todd.white@thalion.global>

* Headers/AppKit/NSDataLinkManager.h:
* Source/NSDataLinkManager.m: Watch the source file of a data
link with whatever the platform provides. inotify reports the
file; on Windows a change notification handle reports its
directory, and every link taking its source from there is
reported; where there is neither, a timer compares each file's
modification date and size. Before this the manager built and
accepted links on a platform with no inotify and never asked
the delegate, so a link never refreshed.

2026-08-11 Todd White <todd.white@thalion.global>

* Source/NSApplication.m: Set the hidden flag, post the hide
Expand Down
7 changes: 7 additions & 0 deletions Headers/AppKit/NSDataLinkManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,13 @@ APPKIT_EXPORT_CLASS
NSThread *_monitorThread;
int _inotifyFD;
NSMutableDictionary *_watchDescriptors;
/* The source file of each watched link, by path. Every mechanism needs it:
the Windows watcher to say which link a directory's change belongs to, and
the timer to know which files to examine. */
NSMutableDictionary *_watchedLinks;
/* How each source file was last seen: its modification date and size. */
NSMutableDictionary *_watchedStamps;
id _pollTimer;

struct __dlmFlags {
unsigned areLinkOutlinesVisible:1;
Expand Down
Loading