Skip to content

fix(errors): fix error wrapping - #165

Merged
fredbi merged 1 commit into
go-openapi:masterfrom
fredbi:fix/duplicated-loader-sentinel
Aug 14, 2026
Merged

fix(errors): fix error wrapping#165
fredbi merged 1 commit into
go-openapi:masterfrom
fredbi:fix/duplicated-loader-sentinel

Conversation

@fredbi

@fredbi fredbi commented Aug 14, 2026

Copy link
Copy Markdown
Member

We add a check before wrapping errors, preventing the package-level sentinel error to be added multiple times, and show untidy duplicate error messages.

Change type

Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update

Short description

Fixes

Full description

Checklist

  • I have signed all my commits with my name and email (see DCO. This does not require a PGP-signed commit
  • I have rebased and squashed my work, so only one commit remains
  • I have added tests to cover my changes.
  • I have properly enriched go doc comments in code.
  • I have properly documented any breaking change.

We add a check before wrapping errors, preventing the package-level sentinel error to be added multiple times,
and show untidy duplicate error messages.

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.82%. Comparing base (8538331) to head (70cb1da).
⚠️ Report is 6 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
spec.go 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
+ Coverage   83.61%   83.82%   +0.21%     
==========================================
  Files           5        5              
  Lines         299      303       +4     
==========================================
+ Hits          250      254       +4     
  Misses         31       31              
  Partials       18       18              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@fredbi
fredbi merged commit 3cd66bb into go-openapi:master Aug 14, 2026
20 of 21 checks passed
@fredbi
fredbi deleted the fix/duplicated-loader-sentinel branch August 14, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant