test: rename the fixtures directory to testdata - #298
Merged
Conversation
Test material now lives in testdata/. The Go toolchain gives testdata a defined meaning — package patterns, vet and the build all skip it — whereas fixtures/ was ours alone. The embedded tree in the expander tests is retargeted, along with the paths read out of it; embed places no restriction on testdata. The schemas/ tree embedded by the library itself is untouched, as are the comments that speak of test fixtures as a concept rather than a directory. Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #298 +/- ##
=======================================
Coverage 68.43% 68.43%
=======================================
Files 30 30
Lines 2433 2433
=======================================
Hits 1665 1665
Misses 599 599
Partials 169 169 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test material now lives in testdata/. The Go toolchain gives testdata a defined meaning — package patterns, vet and the build all skip it — whereas fixtures/ was ours alone.
The embedded tree in the expander tests is retargeted, along with the paths read out of it; embed places no restriction on testdata. The schemas/ tree embedded by the library itself is untouched, as are the comments that speak of test fixtures as a concept rather than a directory.
Change type
Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update
Short description
Fixes
Full description
Checklist