Fix/code quality issues - #143
Merged
Merged
Conversation
…rent lengths Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
The limit is 10 levels (which is just theoretical and never happens). Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
The limit is 1000 levels of nesting on user-provided input. The error surfaces to the caller, which is informed of an issue while introspecting the provided value. Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
…a chain of pointers The limit is 1000 levels. The error does not surface: a structure with a chain of more than 1000 nested pointers is simply assumed "not empty". Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (60.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #143 +/- ##
==========================================
- Coverage 91.60% 91.45% -0.15%
==========================================
Files 103 103
Lines 12834 12856 +22
==========================================
+ Hits 11756 11757 +1
- Misses 842 850 +8
- Partials 236 249 +13 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change type
Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update
Short description
Fixes
Full description
Checklist