Skip to content

Forest, Minimal and the site theme: include the password login form #666

Description

@compscidr

Problem

#664 adds password login as a shared partial, _password_login, which the default theme's login.html includes. goblog-theme-forest, goblog-theme-minimal and goblog-site-theme ship their own login.html without it.

A site where a password is the only way to sign in is fine: goblog renders its own login page there, and /login?password=1 always reaches the form. But a site with both GitHub login and a password admin, on one of those themes, shows only the GitHub button.

Fix

In each theme's login.html:

{{ if .password_login_enabled }}{{ template "_password_login" . }}{{ end }}

and raise min_goblog_version to the release that contains #664, since the partial does not exist before it.

Follow-up to #664.

Activity

  1. compscidr commented on Oct 3, 2026

    @compscidr
    CollaboratorAuthor

    Done in all three themes: goblogplatform/goblog-theme-forest#11 (released as v1.5.0), goblogplatform/goblog-theme-minimal#8 (v1.3.0) and goblogplatform/goblog-site-theme#17. Each login page shows goblog's _password_login form under the GitHub button when the site has a password account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions