Skip to content

Forest and the site theme: remove unused templates that point at removed media #677

Description

@compscidr

Problem

goblog v0.15.0 (#676) removed the original author's photos and videos from the image, and the six old default-theme templates that nothing rendered. Two theme repos still carry templates that hardcode those files:

goblog-theme-forest

  • templates/presentations.html → /img/aidecentralized.jpg
  • templates/projects.html → /vid/mesh.mp4
  • templates/research.html → /img/aidecentralized.jpg

goblog-site-theme

  • templates/about.html → /img/hero_rigolet.jpg
  • templates/presentations.html → /img/aidecentralized.jpg
  • templates/projects.html → /vid/mesh.mp4
  • templates/research.html → /img/aidecentralized.jpg

Nothing renders about, presentations or projects (their handlers were never routed and are now removed). research.html is not used by the Scholar Publications plugin either: the Research page renders through the page templates and its own hero (that is how jasonernst.com's Research hero is set). So all of them are dead, and would show broken media if anything ever did render them.

Both themes also ship their own copies of the other removed templates (archives.html, posts.html, tags.html), equally unused.

Fix

In each theme, delete the templates goblog no longer renders: about, archives, posts, presentations, projects, research, tags (whichever the theme has). Before deleting research.html, confirm with a quick grep that nothing in goblog or the Scholar plugin names that template. Bump Forest's version and changelog; the site theme just redeploys.

Follow-up to #669 / #676.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions