Skip to content

Install: neutral defaults instead of the author's personal details - #660

Merged
compscidr merged 1 commit into
mainfrom
fix/neutral-install-defaults
Oct 3, 2026
Merged

compscidr merged 1 commit into
mainfrom
fix/neutral-install-defaults

Conversation

@compscidr

Copy link
Copy Markdown
Collaborator

Closes #657.

Problem

A new user who clicked through the install wizard got a site in the original author's name:

  • The settings step was pre-filled with "Jason Ernst", "Software Engineer", "JE", personal site tags and ten personal profile URLs.
  • A fresh database was seeded with the same title, subtitle, logo letters and tags.
  • The seeded About page contained the author's biography. (This one was not in the issue; I found it while fixing the rest.)

Changes

  • wizard_settings.html: title "My Blog", logo letters "MB"; subtitle, tags and the profile URLs are empty with placeholder hints (https://github.com/you).
  • seedDefaultSettings: same title and logo letters, empty subtitle and tags.
  • seedDefaultPages: the About page says what it is and that it is edited under Admin → Pages.

Existing sites are unaffected: settings are seeded only when the key is missing, and pages only into an empty table.

Not changed

  • Bundled images. The default landing image (/img/profile.png) and the About page's hero (/img/hero_rigolet.jpg) are still the author's own pictures, and www/img also ships jason.jpg. They need replacement artwork, which I can't supply.
  • themes/default/templates/about.html still has the biography hardcoded. Nothing routes to it (Blog.About is not registered), so it is dead rather than visible.
  • The profile URL fields in the wizard save to settings that the Social Icons plugin reads, and that plugin is no longer built in. They may be leftovers worth removing from the wizard.

Testing

go test ./... passes, and the install smoke test passes on SQLite with these seeds. I did not look at the wizard page in a browser.

🤖 Generated with Claude Code

The wizard's settings step was pre-filled with the original author's
name, job title, tags and ten personal profile URLs, and a fresh
database was seeded with the same title, subtitle, logo letters and tags
plus an About page holding the author's biography. Clicking through the
wizard produced a site in someone else's name.

The wizard now offers "My Blog" / "MB" and placeholders for the rest,
the seeds match, and the seeded About page says what it is and where to
edit it. Existing sites are unaffected: seeds only fill missing keys and
pages are only seeded into an empty table.

Closes #657.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 3, 2026 15:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The change only substitutes neutral string literals for personal ones in seed/template code, is internally consistent, and breaks no existing tests.

Review effort: Balanced
Findings: None

What changed in this PR

This PR removes the original author's personal details from GoBlog's install experience so that a fresh install no longer produces a site branded with someone else's name and profile links. It addresses issue #657 by swapping personal defaults for neutral ones in both the install wizard template and the database seed functions.

Changes:

  • wizard_settings.html: neutral title ("My Blog") and logo letters ("MB"); empties the subtitle, tags and all ten social profile URLs, adding placeholder hints instead.
  • seedDefaultSettings: mirrors the wizard with the same neutral title/letters and empty subtitle/tags.
  • seedDefaultPages: replaces the author's biography on the seeded About page with generic guidance pointing to Admin → Pages.
File Description
tools/​migrate.go Neutralizes seeded site_title/site_logo_letters, empties subtitle/tags, and replaces the seeded About page's biography with generic placeholder text.
themes/​default/​templates/​wizard_settings.html Replaces personal pre-filled values with neutral defaults and placeholder hints for site fields and all social URL inputs.

I verified the seeded values stay consistent between the wizard and seedDefaultSettings, that the "Admin → Pages" reference matches the real /admin/pages route and nav link, that no tests assert on the old personal values (so nothing breaks), and that the default theme is the only one carrying a wizard template. Remaining author-specific assets (hero_rigolet.jpg, redtree.mp4, about.html) fall outside the changed regions and are explicitly acknowledged as out of scope in the PR description.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codecov

codecov Bot commented Oct 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@compscidr
compscidr merged commit 08b69fb into main Oct 3, 2026
6 of 7 checks passed
@compscidr
compscidr deleted the fix/neutral-install-defaults branch October 3, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Install wizard's settings step is pre-filled with the author's personal details

2 participants