Repository navigation
Wizard: drop the social profile fields - #662
Conversation
The settings step asked for ten profile URLs (GitHub, LinkedIn, X, ...) and saved them as site settings. Those are read only by the Social Icons plugin, which has not been built in since 0.7.0, so on a fresh install they did nothing. The plugin has its own settings page once installed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
It is a self-contained template-only deletion with no code depending on the removed fields, and the dynamic settings-save path and the retained migration were both verified unaffected.
Review effort: Balanced
Findings: None
What changed in this PR
This PR simplifies the install wizard's settings step by removing ten social profile URL fields (GitHub, LinkedIn, X, Keybase, Instagram, Facebook, Strava, Spotify, Xbox, Steam) from wizard_settings.html. These values were only consumed by the Social Icons plugin, which has not been built in since 0.7.0, so on a fresh install they did nothing while tripling the length of the settings step. The step now collects only site title, subtitle, logo letters, tags, landing image, and favicon. It is a follow-up to #657, and the existing tools/migrate.go migration that moves these keys to the plugin's settings for upgraded sites is intentionally left untouched.
Changes:
- Removed the "Socials" heading and the ten social URL input fields from the wizard settings template.
- No server-side or JavaScript changes required, since the settings save logic iterates form inputs dynamically.
| File | Description |
|---|---|
| themes/default/templates/wizard_settings.html | Removes the social profile URL section, leaving the core site-identity fields in the install wizard's settings step. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The install wizard's settings step asked for ten profile URLs (GitHub, LinkedIn, X, Keybase, Instagram, Facebook, Strava, Spotify, Xbox, Steam) and saved them as site settings.
Those values are only read by the Social Icons plugin, which has not been built in since 0.7.0. On a fresh install they did nothing, and they made the settings step three times as long as it needs to be. Once the plugin is installed from Admin → Plugins it has its own settings page for them.
The step now asks for the site title, subtitle, logo letters, tags, landing image and favicon.
Left alone: the migration in
tools/migrate.gothat moves those keys from old sites' settings into the plugin's settings.Testing: the template still parses (
go test . ./theme). I did not look at the page in a browser. The install smoke test does not post these fields, so CI covers the step without them.Follow-up to #657.
🤖 Generated with Claude Code