Print the GitHub button's URL instead of assembling it

[compscidr]

Follow-up to goblogplatform/GoBlog#639.

Why

#631 moved GitHub's authorize URL into Go so the escaping was decided once. It left this theme assembling the URL that reaches it:

href="/login/github{{ if .next }}{{ if ne .next "/" }}?next={{ .next | urlquery }}{{ end }}{{ end }}"

A nested conditional building a URL, in markup, duplicated across four theme repositories.

goblog decides it now, so the template prints one value:

href="{{ .github_login_url }}"

The URL's shape becomes the server's business — if it ever needs another parameter, this theme does not change again.

Merge order

goblogplatform/GoBlog#639 first. Without it .github_login_url is unset and the button renders an empty href.

🤖 Generated with Claude Code

[Copilot]

Copilot review overview

🟡 Changes recommended

As written, GitHub sign-in can silently break when .github_login_url is missing/empty (e.g., theme upgraded ahead of server), so a small template-level fallback is needed for safe rollout.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1

Open (1)

• Add fallback GitHub login URL when github_login_url is missing · New

What changed in this PR

Updates the login template to rely on a server-provided GitHub login URL (.github_login_url) rather than building the /login/github?... URL in the theme, keeping URL-shaping logic centralized in goblog.

Changes:

• Replace inline conditional URL construction for the GitHub login button with {{ .github_login_url }}.

File	Description
templates/​login.html	Switch GitHub login button to print server-provided login URL instead of assembling query params in-template.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[compscidr]

Real risk, and worth guarding — but with min_goblog_version rather than a template fallback. Bumped to 0.12.0 in 8e56594.

goblog already has a gate for exactly this. theme/installer checks the manifest before anything is written:

if !pinstaller.Compatible(i.Version, e.MinGoblogVersion) {
    return directory.Entry{}, fmt.Errorf("%w (%s; this is %s)", ErrIncompatible, e.MinGoblogVersion, i.Version)
}

and the listing shows "requires goblog 0.12.0 or newer" instead of an install button. That prevents the mismatch rather than degrading to a link that still works but has lost its next — and a fallback in the markup would put back the conditional this PR exists to remove.

Worth noting the dependency is not only .github_login_url: this theme's login page also stopped handling ?code= itself, because goblog completes the OAuth flow server-side against a state it minted (goblogplatform/GoBlog#638). On an older goblog that half is broken too, and no template fallback could paper over it. One version gate covers both.

0.12.0 is an assumption — it is the next goblog release, carrying #638 and #639, neither released yet (latest is v0.11.0). If that lands under a different number this needs to match.