Skip to content

Use goblog's shared _powered_by partial for the footer credit - #9

Merged
compscidr merged 1 commit into
mainfrom
feat/shared-powered-by
Oct 3, 2026
Merged

compscidr merged 1 commit into
mainfrom
feat/shared-powered-by

Conversation

@compscidr

@compscidr compscidr commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Why

goblogplatform/GoBlog#644 moves the "Powered by goblog" credit into a shared partial, _powered_by, and adds a Show "Powered by goblog" setting that hides it. This theme wrote the line out itself, linking to the GitHub repository, so the setting had no effect here.

What

  • footer.html includes {{ template "_powered_by" . }} inside the same styled <p> as before. The link now goes to https://www.goblog.live.
  • goblog.css gains .powered-by a { color: inherit; }, replacing the inline colour the link used to carry, so it looks the same.
  • min_goblog_version goes to 0.13.0 and the changelog gets an entry.

Requires goblog 0.13.0

goblogplatform/GoBlog#644 is merged and shipped in goblog v0.13.0, which contains the _powered_by partial. The manifest and changelog here already say 0.13.0. The changelog entry is included here rather than in a separate release PR.

Testing

Validated with theme.ValidateFiles against the goblog#644 branch, and rendered footer.html with the setting on (credit shown) and off (credit absent). Not checked in a browser.

🤖 Generated with Claude Code

The footer wrote out its own "Powered by goblog" link to the GitHub
repository. Include goblog's shared _powered_by partial instead, so the
link goes to goblog.live and the show_powered_by setting can hide it.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@compscidr
compscidr marked this pull request as ready for review October 3, 2026 07:36
Copilot AI balanced review requested due to automatic review settings October 3, 2026 07:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The partial contract, matching .powered-by CSS selector, and 0.13.0 min-version requirement were each verified against the shipped goblog v0.13.0 release, and no objective issues were found in this small presentational change.

Review effort: Balanced
Findings: None

What changed in this PR

This PR updates the Forest theme for goblog so its footer "Powered by goblog" credit comes from goblog's shared _powered_by partial (introduced in goblogplatform/GoBlog#644) rather than being hand-written in the theme. This makes the new Show "Powered by goblog" admin setting take effect on this theme and points the credit link at goblog.live instead of the GitHub repo. I verified the _powered_by partial ships in the goblog v0.13.0 release and renders <span class="powered-by">Powered by <a href="https://www.goblog.live" …>goblog …</a></span>, so the new CSS selector and the min-version bump line up correctly.

Changes:

  • footer.html renders {{ template "_powered_by" . }} inside the same styled <p>; the partial emits an inline <span>, so the markup stays valid.
  • Adds .powered-by a { color: inherit; } so the link inherits the surrounding rgba(255,255,255,0.4) color, matching the previous inline color exactly.
  • Bumps min_goblog_version to 0.13.0 (the first release containing the partial) and documents the change in CHANGELOG.md (1.4.0).
File Description
templates/​footer.html Replaces the hand-written credit line with the shared _powered_by partial include.
static/​css/​goblog.css Adds .powered-by a { color: inherit; } to preserve the credit link's footer color.
goblog-theme.json Raises min_goblog_version to 0.13.0 to require the release that provides the partial.
CHANGELOG.md Adds a 1.4.0 entry describing the partial switch and new goblog requirement.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@compscidr
compscidr merged commit e6311e7 into main Oct 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants