Skip to content

Use goblog's shared _powered_by partial for the footer credit - #7

Merged
compscidr merged 1 commit into
mainfrom
feat/shared-powered-by
Oct 3, 2026
Merged

compscidr merged 1 commit into
mainfrom
feat/shared-powered-by

Conversation

@compscidr

@compscidr compscidr commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Why

goblogplatform/GoBlog#644 moves the "Powered by goblog" credit into a shared partial, _powered_by, and adds a Show "Powered by goblog" setting that hides it. This theme wrote the line out itself, linking to the GitHub repository, so the setting had no effect here.

What

  • footer.html includes {{ template "_powered_by" . }} inside the same styled <p> as before. The link now goes to https://www.goblog.live.
  • goblog.css gains .powered-by a { color: inherit; }, replacing the inline colour the link used to carry, so it looks the same.
  • min_goblog_version goes to 0.13.0 and the changelog gets an entry.

Requires goblog 0.13.0

goblogplatform/GoBlog#644 is merged and shipped in goblog v0.13.0, which contains the _powered_by partial. The manifest and changelog here already say 0.13.0. The changelog entry is included here rather than in a separate release PR.

Testing

Validated with theme.ValidateFiles against the goblog#644 branch, and rendered footer.html with the setting on (credit shown) and off (credit absent). Not checked in a browser.

🤖 Generated with Claude Code

The footer wrote out its own "Powered by goblog" link to the GitHub
repository. Include goblog's shared _powered_by partial instead, so the
link goes to goblog.live and the show_powered_by setting can hide it.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@compscidr
compscidr marked this pull request as ready for review October 3, 2026 07:36
Copilot AI balanced review requested due to automatic review settings October 3, 2026 07:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The small, well-scoped change correctly consumes goblog's shared _powered_by partial, the CSS selector matches the partial's verified markup, and the bumped min_goblog_version points to a real released version containing it.

Review effort: Balanced
Findings: None

What changed in this PR

This PR migrates the Minimal goblog theme's footer credit to use goblog's shared _powered_by partial (introduced in goblogplatform/GoBlog#644) instead of writing out its own "Powered by goblog" line. Previously the theme hardcoded the credit with a link to the GitHub repo, which meant goblog's new Show "Powered by goblog" setting had no effect on this theme. By delegating to the partial, the setting now works here and the link points to goblog.live, consistent with the default theme.

Changes:

  • Replace the hardcoded footer credit with {{ template "_powered_by" . }}, keeping the same styled <p> wrapper.
  • Add .powered-by a { color: inherit; } so the partial's link matches the surrounding footer color (replacing the previous inline color).
  • Bump min_goblog_version to 0.13.0 (the first release containing the partial) and add a 1.2.0 changelog entry.
File Description
templates/​footer.html Swaps the hand-written credit line for the shared _powered_by partial.
static/​css/​goblog.css Adds .powered-by a { color: inherit; } so the partial's link keeps the footer color.
goblog-theme.json Raises min_goblog_version to 0.13.0, which contains the partial.
CHANGELOG.md Documents the change and the new goblog 0.13.0 requirement under 1.2.0.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@compscidr
compscidr merged commit e43008b into main Oct 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants