Clarify double asterisk behaviour - #65
Closed
jamiecobbett wants to merge 1 commit into
Closed
Conversation
I did not understand what "super-asterisk" means, and I had naively assumed that the behaviour would match glob implementations I am used to.
gobwas
added a commit
that referenced
this pull request
Aug 28, 2026
The regexps in BenchmarkCompareGlobAndRegexp now carry the `s` flag and escaped dots, so they are the exact equivalents of the globs; refresh both tables from a single run. Explain that `**` is not the shells' globstar and add an Escaping section (backslashes in Go string literals). Fixes: #21, #35, #38, #58, #65
Owner
|
The readme was rewritten as part of v1 (#73, now merged) and covers this -- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did not understand what "super-asterisk" means, and I had naively assumed that the behaviour would match glob implementations I am used to.
If there's anything that was described in the existing copy that I've missed, please let me know.
Thanks for making this library 👍