build(deps): upgrade cli-engine to 0.9 and progenitor to 0.14 for reqwest 0.13 - #228
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades core HTTP/client dependencies to align the workspace with reqwest 0.13 (via cli-engine 0.9.0 and progenitor/progenitor-client 0.14), and adjusts CLI flags to avoid a new global -i collision introduced by cli-engine.
Changes:
- Bump
cli-engineto0.9.0and update the workspacereqwestdependency to0.13with the renamed/split TLS/form features. - Bump
domains-client’sprogenitor/progenitor-clientto0.14and move it toreqwest0.13. - Remove the
-ishort flag fromapi call --includeandapi graphql call --includeto avoid collision with the new global--interactive/-i.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rust/src/api_explorer/graphql/call.rs | Drops -i short flag from --include for GraphQL calls to avoid global -i collision. |
| rust/src/api_explorer/call.rs | Drops -i short flag from --include for REST calls to avoid global -i collision. |
| rust/domains-client/Cargo.toml | Updates progenitor* and reqwest versions/features to reqwest 0.13 compatibility. |
| rust/Cargo.toml | Bumps cli-engine and moves the main crate to reqwest 0.13 with updated feature flags (rustls, form). |
| rust/Cargo.lock | Lockfile updates reflecting the dependency upgrades and new transitive deps from reqwest/rustls changes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…west 0.13 cli-engine 0.9.0 moved to reqwest 0.13 (aws-lc-rs-backed rustls, renamed rustls feature). domains-client follows suit: progenitor/progenitor-client 0.11 -> 0.14 to pick up the matching reqwest 0.13 generated client, keeping the whole workspace on one reqwest major version. cli-engine 0.9.0 also added a global --interactive/-i flag, which collided with api call/graphql call's own --include/-i. Dropped the short form from --include (long flag only) to resolve it.
jpage-godaddy
force-pushed
the
progenitor-upgrade
branch
from
August 24, 2026 22:03
a95abc7 to
93ae8dc
Compare
qcai-godaddy
approved these changes
Aug 24, 2026
This was referenced Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cli-engineto 0.9.0, which moved to reqwest 0.13 (aws-lc-rs-backed rustls,rustls-tlsfeature renamed torustls, form-encoded bodies split into a newformfeature).domains-client'sprogenitor/progenitor-clientfrom 0.11 to 0.14 to match — the previous pin was progenitor's last release still on reqwest 0.12; 0.12+ requires reqwest 0.13. Keeps the whole workspace on a single reqwest major version, sincedomains-client'sTransportObservertrait andcli_engine::transport::debug_log_reqwest_request/debug_log_reqwest_responseboth takereqwest::Request/Responseby reference across the crate boundary.--interactive/-iflag, which collided withapi call's andapi graphql call's own--include/-i. Dropped the short form from--include(long flag only).Test plan
cargo checkcargo clippy --all-targets -- -D warningscargo fmt --checkcargo test(693 passed)cargo test -p domains-client(15 passed; generated-client doctests unaffected)./rust/scripts/check-module-size.sh