fix(platform): activate application during deploy - #231
Draft
sgopalan-godaddy wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the platform app deploy flow to explicitly activate the latest release and then promote the parent application to ACTIVE, while avoiding a redundant lifecycle mutation when the application is already active. It also updates user-facing output and documentation so the deploy lifecycle behavior is clearer and the terminal result includes both release and application status.
Changes:
- Activate the parent application to
ACTIVEduring deploy (after activating the latest release), with an idempotency skip when the lookup status is alreadyACTIVE. - Extend the terminal deploy result event to include
applicationStatusalongsidereleaseStatus. - Update platform/deploy documentation and add tests covering application activation behavior and client support for status updates.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rust/src/platform/guides/platform-overview.md | Documents deploy lifecycle behavior (activation + idempotency skip) in the platform overview guide. |
| rust/src/application/commands/deploy/mod.rs | Adds application activation step (with skip logic) and reports applicationStatus in the terminal result event. |
| rust/src/application/client.rs | Adds a client-level test verifying update_application can send a status activation payload. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sgopalan-godaddy
marked this pull request as draft
August 25, 2026 00:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ACTIVEACTIVEVerification
cargo checkcargo clippy -- -D warningscargo test(748 passed)cargo fmt --check./scripts/check-module-size.sh