Skip to content

fix(platform): activate application during deploy - #231

Draft
sgopalan-godaddy wants to merge 1 commit into
godaddy:mainfrom
sgopalan-godaddy:fix/deploy-activate-application
Draft

fix(platform): activate application during deploy#231
sgopalan-godaddy wants to merge 1 commit into
godaddy:mainfrom
sgopalan-godaddy:fix/deploy-activate-application

Conversation

@sgopalan-godaddy

Copy link
Copy Markdown
Contributor

Summary

  • activate the latest release before promoting its parent application to ACTIVE
  • skip the application lifecycle mutation when lookup already reports ACTIVE
  • report both release and application status in the terminal deploy result
  • document deploy lifecycle behavior and cover the activation request/idempotency decision

Verification

  • cargo check
  • cargo clippy -- -D warnings
  • cargo test (748 passed)
  • cargo fmt --check
  • ./scripts/check-module-size.sh

Copilot AI lite review requested due to automatic review settings August 24, 2026 23:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the platform app deploy flow to explicitly activate the latest release and then promote the parent application to ACTIVE, while avoiding a redundant lifecycle mutation when the application is already active. It also updates user-facing output and documentation so the deploy lifecycle behavior is clearer and the terminal result includes both release and application status.

Changes:

  • Activate the parent application to ACTIVE during deploy (after activating the latest release), with an idempotency skip when the lookup status is already ACTIVE.
  • Extend the terminal deploy result event to include applicationStatus alongside releaseStatus.
  • Update platform/deploy documentation and add tests covering application activation behavior and client support for status updates.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
rust/src/platform/guides/platform-overview.md Documents deploy lifecycle behavior (activation + idempotency skip) in the platform overview guide.
rust/src/application/commands/deploy/mod.rs Adds application activation step (with skip logic) and reports applicationStatus in the terminal result event.
rust/src/application/client.rs Adds a client-level test verifying update_application can send a status activation payload.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@sgopalan-godaddy
sgopalan-godaddy marked this pull request as draft August 25, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants