-
Notifications
You must be signed in to change notification settings - Fork 25
feat(platform): add support for settings-link-v1 schema #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nmolham-godaddy
wants to merge
15
commits into
godaddy:main
Choose a base branch
from
nmolham-godaddy:feat/settings-link-v1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
f5122d3
Define settings-link-v1 and settings presentation enum
nmolham-godaddy 8400165
Enhance presentation file structures for forms and links
nmolham-godaddy 3f30e44
Add setting-link-v1 validation
nmolham-godaddy fcb5dd8
Add test coverage
nmolham-godaddy 986d0bc
Pass validation with allowed capabilities
nmolham-godaddy cf964a4
Update tests
nmolham-godaddy 3d04a8c
Update mod tests
nmolham-godaddy 9eee24e
Support full presentation formats in releases
nmolham-godaddy 6c537c8
Clarify lifecycle capabilities and update command documentation for s…
nmolham-godaddy 4e85c0d
Update smoke tests to cover settings-link-v1
nmolham-godaddy 2df919a
Update usage docs
nmolham-godaddy eaaf74f
Formatting fix
nmolham-godaddy a58c370
Lint fix
nmolham-godaddy a63291a
fix: reject non-string type in presentation JSON
nmolham-godaddy 61cb342
Add smoke test to CICD workflow
nmolham-godaddy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to maintain this file or is the guide sufficient?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is nice to have, specially GPA settings usage is a bit complex at the beginning