Skip to content

Update Android NDK version in export-android.md - #146

Open
hminy572 wants to merge 3 commits into
godot-rust:masterfrom
hminy572:master
Open

hminy572 wants to merge 3 commits into
godot-rust:masterfrom
hminy572:master

Conversation

@hminy572

Copy link
Copy Markdown

Description

This PR updates an outdated reference to the Android NDK version in the Android export documentation (toolchain/export-android.md).

The document previously stated that Godot relies on NDK version 23.2.8568313, which is outdated. It has been updated to reference the correct current version, 29.0.14206865.

Changes

  • Updated NDK version string from 23.2.8568313 to 29.0.14206865 in the Android export example.

Checklist

  • The change is a simple documentation typo/version fix.
  • No code modifications were made.

Update Android NDK version in export-android.md
@Bromeon Bromeon added the outdated-api Information that is no longer accurate label Jun 24, 2026
@Bromeon

Bromeon commented Jun 24, 2026

Copy link
Copy Markdown
Member

Thank you!

This is bound to become outdated again; I wonder if we should just point to the link
https://github.com/godotengine/godot/blob/master/platform/android/java/app/config.gradle#L16
instead? Since the user anyway has to double-check the link and can't be confident in what we write, there's not much benefit in copying the version, is there? 🤔

@hminy572

hminy572 commented Jun 24, 2026 •

Copy link
Copy Markdown
Author

Thank you for replying! I 100% agree with you. Should I open another pr without hard-coding ndk version? Since this is my first time pr, I'm not used to pr protocol yet.

@Bromeon

Bromeon commented Jun 24, 2026

Copy link
Copy Markdown
Member

No, please don't open a new PR 🙂
You can just change your commit:

git commit --amend

And then check if everything is correct:

git log -n1
git diff HEAD~1

If yes, force-push to update this branch here:

git push --force-with-lease

Updated NDK version reference for clarity.
@hminy572

Copy link
Copy Markdown
Author

Thanks for the instructions! I removed version specification and made the sentence simple. Please let me know if there are any issues.

@Bromeon Bromeon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would mention the key type, just so it's immediately clear what to look for 🙂

Comment thread src/toolchain/export-android.md Outdated
@hminy572

Copy link
Copy Markdown
Author

With key type, that looks a lot better!

@Bromeon
Bromeon force-pushed the master branch 5 times, most recently from 7332cd3 to df24ed3 Compare June 30, 2026 20:44
I applid this change!

Co-authored-by: Jan Haller <bromeon@gmail.com>
@hminy572

Copy link
Copy Markdown
Author

I'm so sorry for late reply. I really appreciate your hardwork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

outdated-api Information that is no longer accurate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants