Repository navigation
fix(cli): reject flags that were accepted and silently ignored - #359
Merged
Merged
Conversation
Follows the d661d88 rule: validate explicit user input. - `index rebuild --max-concurrent N` was parsed and never read; the core reindex seam is sequential. Remove the flag so passing it is an "unknown argument" error instead of a no-op. The e2e test now asserts the rejection. - `skill search --embedding` only applies to local search, and remote is the default scope, so `skill search "q" --embedding true` quietly ran a remote search. Reject --embedding without --local, like --paths. The QA smoke plan had three local-search steps missing --local, and they were silently exercising remote search; add --local. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two CLI flags were accepted and then silently ignored. This follows the rule from d661d88: validate explicit user input.
index rebuild --max-concurrent Nwas parsed and never read, because indexing is sequential. The flag is removed, so passing it is now anunknown argumenterror. This breaks scripts that pass the flag, which previously did nothing.skill search --embeddingonly applies to local search, and remote is the default scope. Soskill search "q" --embedding truequietly ran a remote search. It now errors unless--localis given, like--paths.--localand had been silently exercising remote search. They now pass--local.Test plan
--max-concurrentis rejected.--embeddingwithout--local.scripts/run-tests.shpasses locally: 1956 passed, 0 failed.🤖 Generated with Claude Code