Skip to content

tiff: limit LZW block reads to the block's exact size - #36

Open
lazerg wants to merge 1 commit into
golang:masterfrom
lazerg:fix/tiff-lzw-block-overread
Open

lazerg wants to merge 1 commit into
golang:masterfrom
lazerg:fix/tiff-lzw-block-overread

Conversation

@lazerg

@lazerg lazerg commented Sep 6, 2026

Copy link
Copy Markdown

tiff: limit LZW block reads to the block's exact size

Strips compressed with LZW were read with an oversized limit,
widthheight8, enough for RGBA64, so decoding kept demanding data
past the point where a strip's pixels were already fully decoded.
Whatever followed, end of input or a code the LZW dictionary hadn't
defined yet, turned into unexpected EOF or lzw: invalid code,
discarding a strip that had already decoded correctly.

Compute the exact number of bytes a block needs from its width,
height, samples per pixel and bits per sample, and use that as the
read limit instead, falling back to the old bound when it can't be
computed. decode already reports "not enough pixel data" for a block
that comes back short, so a genuinely truncated strip is still caught.

The same over-read is possible for the other compressions still on
the old bound; this only touches LZW, the one actually observed and
tested here.

Fixes golang/go#81347

Strips compressed with LZW were read with an oversized limit,
width*height*8, enough for RGBA64, so decoding kept demanding data
past the point where a strip's pixels were already fully decoded.
Whatever followed, end of input or a code the LZW dictionary hadn't
defined yet, turned into unexpected EOF or lzw: invalid code,
discarding a strip that had already decoded correctly.

Compute the exact number of bytes a block needs from its width,
height, samples per pixel and bits per sample, and use that as the
read limit instead, falling back to the old bound when it can't be
computed. decode already reports "not enough pixel data" for a block
that comes back short, so a genuinely truncated strip is still caught.

The same over-read is possible for the other compressions still on
the old bound; this only touches LZW, the one actually observed and
tested here.

Fixes golang/go#81347
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 8800f93) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/image/+/828484.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

x/image/tiff: LZW block read past its last pixel fails on trailing data

2 participants