Repository navigation
Add overlay hosting, modal dialogs, and anchored ComboBox popups - #24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add UIContext-owned overlays and reusable modal dialogs, then build anchored transient popups and a non-editable ComboBox on the same ownership and dispatch mechanisms.
Changes
Validation
LIBGL_ALWAYS_SOFTWARE=1 xvfb-run -a ctest --preset debug/release: 9/9 suites passed in each./tmp.git diff --checkpassed.Presentation investigation and limits
The original intermittent all-black root capture was not reproduced and its cause remains unproven. Explicit GL front reads can be black while native captures are correct, and post-swap/idle reads can perturb resize presentation; the minimal GLFW control reproduces these effects. Live desktop client capture succeeds while root capture returns BadMatch. The report distinguishes those observations from a confirmed MyGUI defect.
Windows and macOS were not tested locally. Raw captures and logs remain in the ignored local build directory; the committed diagnostic tools and report provide reproduction commands.