Support untied-head attention-sink LlamaSimpleMLP targets - #1002
Open
claude-spd1 wants to merge 3 commits into
Open
claude-spd1 wants to merge 3 commits into
claude-spd1 wants to merge 3 commits into
Conversation
added 3 commits
September 8, 2026 06:01
Crew-Address: agent/ig9m
Crew-Address: agent/i9y2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the untied-output-head and learned attention-sink variant of the 4-layer
LlamaSimpleMLPtarget to the public loader and pretrainer. Clean and decomposed forwards share the same sink-aware attention implementation, and the cache contract records both new model facts.Related Issue
Bridge task #1423.
Motivation and Context
The completed #1423 decomposition and base-model bundles need a public consumer that reconstructs their exact architecture. Without this change, public
param-decompassumes a tied output head and plain causal attention and cannot load those artifacts faithfully.How Has This Been Tested?
pytest -q param_decomp/tests/core/test_pretrain.py param_decomp/tests/targets/test_llama_simple_mlp.py(21 passed, 1 skipped)pytest -q param_decomp/tests/core/test_config.py param_decomp/tests/targets/simple_mlp_equivalence/test_torch_equivalence.py(22 passed, 1 skipped)Does this PR introduce a breaking change?
No. Existing configs default to tied embeddings and no attention sinks.
Diff breakdown
Crew-Address: agent/i9y2
Bridge-Task: 1423