Repository navigation
fix(lint): scope Biome off pre-existing web-client and docs debt - #366
Open
chopmob-cloud wants to merge 1 commit into
Open
chopmob-cloud wants to merge 1 commit into
chopmob-cloud wants to merge 1 commit into
Conversation
The required Lint Code Base check runs Super-Linter Biome across the whole repository, so every PR inherits the pre-existing Biome errors in code/web-client and docs/assets rather than seeing only its own changes (see google-agentic-commerce#306). This adds a minimal biome.json that keeps Biome on the rest of the tree but excludes those two debt folders, so the gate reflects PR content. No workflow (linter.yaml) change, so the zizmor gate is unaffected. Signed-off-by: AlgoVoi <chopmob@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
The required
Lint Code Basecheck runs Super-Linter's Biome across the whole repository, so every PR's Lint run reports the pre-existing Biome errors incode/web-clientanddocs/assets(75 diagnostics in recent runs) rather than only the PR's own changes. This is the out-of-diff scanning described in #306, and it currently reds otherwise-clean PRs.This adds a minimal
biome.jsonthat excludes those two directories from Biome:{ "files": { "includes": ["**", "!code/web-client", "!docs/assets"] } }Tradeoff (please decide deliberately)
This is a coverage exclude, not diff-scoping. It removes
code/web-clientanddocs/assetsfrom Biome for all future changes in those directories, not only for the current diff, for as long as this configuration applies. It unblocks the required gate immediately and touches no workflow (so the zizmor gate is unaffected) and no source, but it trades away Biome coverage of those two trees.The alternative is #311, which instead clears the existing Biome errors so Biome keeps full coverage. The two approaches target the same goal and are mutually exclusive:
Posting this as the minimal-unblock option so maintainers can choose explicitly between the two. If #311 is preferred, this PR can be closed.
Type of Change