Skip to content

fix(lint): scope Biome off pre-existing web-client and docs debt - #366

Open
chopmob-cloud wants to merge 1 commit into
google-agentic-commerce:mainfrom
chopmob-cloud:fix/biome-scope-306
Open

chopmob-cloud wants to merge 1 commit into
google-agentic-commerce:mainfrom
chopmob-cloud:fix/biome-scope-306

Conversation

@chopmob-cloud

@chopmob-cloud chopmob-cloud commented Sep 30, 2026 •

Copy link
Copy Markdown

What this does

The required Lint Code Base check runs Super-Linter's Biome across the whole repository, so every PR's Lint run reports the pre-existing Biome errors in code/web-client and docs/assets (75 diagnostics in recent runs) rather than only the PR's own changes. This is the out-of-diff scanning described in #306, and it currently reds otherwise-clean PRs.

This adds a minimal biome.json that excludes those two directories from Biome:

{
  "files": {
    "includes": ["**", "!code/web-client", "!docs/assets"]
  }
}

Tradeoff (please decide deliberately)

This is a coverage exclude, not diff-scoping. It removes code/web-client and docs/assets from Biome for all future changes in those directories, not only for the current diff, for as long as this configuration applies. It unblocks the required gate immediately and touches no workflow (so the zizmor gate is unaffected) and no source, but it trades away Biome coverage of those two trees.

The alternative is #311, which instead clears the existing Biome errors so Biome keeps full coverage. The two approaches target the same goal and are mutually exclusive:

Posting this as the minimal-unblock option so maintainers can choose explicitly between the two. If #311 is preferred, this PR can be closed.

Type of Change

  • Maintenance (CI)

The required Lint Code Base check runs Super-Linter Biome across the whole
repository, so every PR inherits the pre-existing Biome errors in
code/web-client and docs/assets rather than seeing only its own changes
(see google-agentic-commerce#306). This adds a minimal biome.json that keeps Biome on the rest of the
tree but excludes those two debt folders, so the gate reflects PR content. No
workflow (linter.yaml) change, so the zizmor gate is unaffected.

Signed-off-by: AlgoVoi <chopmob@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant