Repository navigation
chore(cspell): add PISP and SECP terms to custom words - #379
Open
baaakgun4543 wants to merge 1 commit into
Open
baaakgun4543 wants to merge 1 commit into
baaakgun4543 wants to merge 1 commit into
Conversation
constraints.py and its tests use PISP (payment initiation service provider) identifiers and the SECP256R1 curve name. They are not in the dictionary, so any PR touching those files fails the incremental spellcheck.
This was referenced Oct 14, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
constraints.pyandconstraints_tests.pyuse the PISP identifiers (payment initiation service provider:AllowedPisps,closed_mandate.pisp, ...) and theSECP256R1curve name. None of these words is in.cspell/custom-words.txt. Because the spellcheck workflow checks every word in any changed file, a PR that touches either file fails spellcheck even when it adds no new words. This currently happens on #377 and #378.This adds the exact forms reported by cspell, since the config is case-sensitive:
otherpisp,PISP,Pisp,pisp,Pisps,SECP. They are inserted in the file's existing near-alphabetical order. No code changes.CONTRIBUTINGGuide.