Repository navigation
fix: resolve Biome lint errors in web-client and docs SVG - #382
Open
maximusrufus wants to merge 6 commits into
Open
maximusrufus wants to merge 6 commits into
maximusrufus wants to merge 6 commits into
Conversation
4 tasks done
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
- Add explicit type="button" to buttons; mark decorative SVGs aria-hidden - Replace `any` and non-null assertions with typed/guarded code - Add fetchMandate to sendToAgent deps (stable callback); document intentional dependency lists with biome-ignore comments - Drop dead code and unused imports in mandateEntries - Strip XML prolog/DOCTYPE from mandate_delegation_user_credential.svg, add a <title>, and a generic font fallback Verified locally: biome lint, eslint, tsc --noEmit and vite build pass.
maximusrufus
force-pushed
the
fix/biome-lint
branch
from
October 16, 2026 15:42
33668e8 to
3a6ff03
Compare
code/web-client has its own eslint config; super-linter's generic ESLint/Prettier lacks React settings and cannot resolve its imports. Strip XML prolog/DOCTYPE/comments from docs SVGs, add titles and a generic font fallback so Biome can parse and lint them.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Super-linter fails on PRs that touch nothing in
code/web-clientordocs/assets(e.g. #352, run 34409230810). This PR makes Lint Code Base, spellcheck and the zizmor Actions scan pass.Web client (
code/web-client/src) — Biome errors fixed: explicittype="button", decorative SVGsaria-hidden, typedimport.meta.env, guarded#root,fetchMandateadded tosendToAgentdeps (stable callback), intentional dep lists annotated withbiome-ignore, dead code removed. No behavior change intended;biome lint,eslint,tsc --noEmit,vite buildpass locally.Super-linter config (
.github/workflows/linter.yaml)code/web-client/likecode/samples/: super-linter's generic ESLint/Prettier has no React config and cannot resolve the app's imports, so any PR touching it failed TSX/TYPESCRIPT_ES/TYPESCRIPT_PRETTIER. The app keeps its owneslint.config.js. Pattern is unanchored because those linters see absolute/github/workspace/...paths.permissions,persist-credentials: false.Docs SVGs (
docs/assets/*.svg) — removed XML prolog/DOCTYPE/comments Biome cannot parse, added<title>,sans-seriffont fallback. Still valid XML.Spellcheck — added
sublabel/Sublabel/dedup;**/*.svgignored (generated IDs).🤖 Generated with Claude Code