Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #372
ParsedToken.cnf_jwkrebuilt the holder key withmodel_dump(exclude_none=True). In Python mode that returnsuseas theUse.sigenum member, and jwcrypto then rejects the key, sokb_sd_jwt.verifyraisedInvalidJWSSignaturefor any hop whose previouscnf.jwkcarried"use": "sig". This change passesmode='json', the same fix #355 applies indelegate_claims_from_model. #355 does not touchcnf_jwk, so the two do not overlap.The added test
test_verify_accepts_cnf_jwk_with_use_and_algbuilds a hop whose rootcnf.jwkincludesuseandalg. It fails on main (InvalidJWSSignature) and passes with this change. Acnf.jwkwithoutusestill verifies as before.Testing:
pytest code/sdk/python/ap2/testsgives 187 passed and 2 failed. The same 2 tests (kb_sd_jwt_intermediate_tests.py::test_verify_rejects_aud_mismatchandtest_verify_rejects_nonce_mismatch) fail identically on main without this change.ruff checkandruff format --checkpass on both changed files.