Repository navigation
fix(sdk): check has_reference_in_store_cb before calling in verify_receipt - #384
Open
aksharprabhudesai wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
has_reference_in_store_cbinReceiptClient.verify_receiptdefaults toNone, but was called unconditionally when checking the receipt reference. If omitted or passed asNone, it raised aTypeError: 'NoneType' object is not callable.This ensures the callback is checked for
Nonebefore being called, and adds test coverage for omitted and explicitNonecallbacks for payment and checkout receipts.CONTRIBUTINGGuide.Fixes #367 🦕