Repository navigation
GNM Visualization: Clean up type annotations, docstrings, and np.newaxis indexing. - #183
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_1007725004
branch
from
October 28, 2026 16:52
09d6ee2 to
16e3aad
Compare
…axis` indexing. - Refine array type annotations (`npt.NDArray[...]`, `FloatArray`) and return annotations across `gnm_mitsuba`, `gnm_pyrender`, `render_common`, and their unit tests. - Standardize docstrings, replace `dict(...)` calls with dict literals, and use `np.newaxis` instead of `None` for array axis expansion. PiperOrigin-RevId: 1009020035
copybara-service
Bot
force-pushed
the
test_1007725004
branch
from
October 28, 2026 17:42
16e3aad to
f0dd7d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GNM Visualization: Clean up type annotations, docstrings, and
np.newaxisindexing.npt.NDArray[...],FloatArray) and return annotations acrossgnm_mitsuba,gnm_pyrender,render_common, and their unit tests.dict(...)calls with dict literals, and usenp.newaxisinstead ofNonefor array axis expansion.