fix(sessions): forward the caller-supplied session id in VertexAiSessionService - #1493
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_978195603
branch
4 times, most recently
from
September 9, 2026 21:29
bcd5eba to
1558091
Compare
…ionService `createSession` accepted a session id but never sent it, so the backend always minted its own. It now travels as the `sessionId` query parameter and is validated first, so an id that fails validation, or that the backend rejects, now errors instead of quietly succeeding under a different id. PiperOrigin-RevId: 978758795
copybara-service
Bot
force-pushed
the
test_978195603
branch
from
September 9, 2026 21:37
1558091 to
77eae25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(sessions): forward the caller-supplied session id in VertexAiSessionService
createSessionaccepted a session id but never sent it, so the backend alwaysminted its own. It now travels as the
sessionIdquery parameter and is validatedfirst, so an id that fails validation, or that the backend rejects, now errors
instead of quietly succeeding under a different id.