Skip to content

Add IsLittleEndian: true to Mach-O yaml2obj test inputs - #526

Merged
jriv01 merged 1 commit into
google:mainfrom
jriv01:macho-yaml-islittleendian
Nov 5, 2026
Merged

jriv01 merged 1 commit into
google:mainfrom
jriv01:macho-yaml-islittleendian

Conversation

@jriv01

@jriv01 jriv01 commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

LLVM llvm/llvm-project#238122 ("[ObjectYAML][MachO] Require IsLittleEndian") makes the top-level IsLittleEndian key of a Mach-O YAML document required. Without it, yaml2obj fails on the tests/macho inputs with "missing required key 'IsLittleEndian'".

Older yaml2obj versions already accept the key as optional, so this change is compatible both before and after the LLVM change.

@walkingeyerobot

Copy link
Copy Markdown
Member

Thanks! This looks good assuming you can get the CI to pass

@jriv01

jriv01 commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks! This looks good assuming you can get the CI to pass

The ubuntu build failure seems to be unrelated (llvm breakage due to a recent upgrade of ubuntu-latest from 24 to 26). Will resolve in a follow-up pull request.

LLVM llvm/llvm-project#238122 ("[ObjectYAML][MachO]
Require IsLittleEndian") makes the top-level `IsLittleEndian` key of a Mach-O
YAML document required. Without it, yaml2obj fails on the tests/macho inputs
with "missing required key 'IsLittleEndian'".

Older yaml2obj versions already accept the key as optional, so this change is
compatible both before and after the LLVM change.

Co-authored-by: Ivan Tadeu Ferreira Antunes Filho <antunesi@google.com>
@jriv01
jriv01 force-pushed the macho-yaml-islittleendian branch from 1363e26 to 89d046e Compare November 5, 2026 20:10
@jriv01
jriv01 merged commit ccb49b0 into google:main Nov 5, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants