Repository navigation
Add IsLittleEndian: true to Mach-O yaml2obj test inputs - #526
Merged
Merged
Conversation
walkingeyerobot
approved these changes
Nov 4, 2026
Member
|
Thanks! This looks good assuming you can get the CI to pass |
Collaborator
Author
The ubuntu build failure seems to be unrelated (llvm breakage due to a recent upgrade of |
LLVM llvm/llvm-project#238122 ("[ObjectYAML][MachO] Require IsLittleEndian") makes the top-level `IsLittleEndian` key of a Mach-O YAML document required. Without it, yaml2obj fails on the tests/macho inputs with "missing required key 'IsLittleEndian'". Older yaml2obj versions already accept the key as optional, so this change is compatible both before and after the LLVM change. Co-authored-by: Ivan Tadeu Ferreira Antunes Filho <antunesi@google.com>
jriv01
force-pushed
the
macho-yaml-islittleendian
branch
from
November 5, 2026 20:10
1363e26 to
89d046e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLVM llvm/llvm-project#238122 ("[ObjectYAML][MachO] Require IsLittleEndian") makes the top-level
IsLittleEndiankey of a Mach-O YAML document required. Without it, yaml2obj fails on the tests/macho inputs with "missing required key 'IsLittleEndian'".Older yaml2obj versions already accept the key as optional, so this change is compatible both before and after the LLVM change.