Repository navigation
Conversation
zlib v1.2.11 declares cmake_minimum_required(VERSION 2.4.4), which CMake 4 rejects. Also add a CI job that builds and tests with CMake 4 and bundled dependencies on Linux and Windows.
This was referenced Nov 6, 2026
Jatapiaro
added a commit
to thebrowsercompany/gha-google-bloaty
that referenced
this pull request
Nov 9, 2026
Working towards: thebrowsercompany/swift-build#368 Allow building bloaty from a fork via a new bloaty-repository input (defaults to google/bloaty), so consumers can use a fixed bloaty while google/bloaty#530 is pending.
Jatapiaro
added a commit
to thebrowsercompany/gha-google-bloaty
that referenced
this pull request
Nov 10, 2026
Working towards: thebrowsercompany/swift-build#368 Allow building bloaty from a fork via a new bloaty-repository input (defaults to google/bloaty), so consumers can use a fixed bloaty while google/bloaty#530 is pending. Tests temporarily point at thebrowsercompany/bloaty@4a4fb50. TODO: switch back to google/bloaty once google/bloaty#530 is merged.
Jatapiaro
added a commit
to thebrowsercompany/swift-build
that referenced
this pull request
Nov 12, 2026
The Bloaty step fails on CMake 4. The bundled zlib 1.2.11 declares cmake_minimum_required(VERSION 2.4.4), and CMake 4 rejects values lower than 3.5. This change builds Bloaty 4a4fb50 from thebrowsercompany/bloaty. That commit updates zlib to v1.3.2. The change also pins gha-google-bloaty to 46ce536 (thebrowsercompany/gha-google-bloaty#5) and adds the Bloaty version to the cache key. When google/bloaty#530 merges, we will go back to google/bloaty. Dry run: https://github.com/thebrowsercompany/swift-build/actions/runs/42911536488 Fixes #368
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundled zlib v1.2.11 declares cmake_minimum_required(VERSION 2.4.4), which CMake 4 rejects, so configuring with bundled dependencies fails:
Changes:
Verified in my fork: the new job passes with zlib v1.3.2 and fails with v1.2.11.