-
Notifications
You must be signed in to change notification settings - Fork 301
x86: size CacheInfo::levels to hold all leaf 2 cache descriptors #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EylonKrause
wants to merge
1
commit into
google:main
Choose a base branch
from
EylonKrause:fix/x86-parseleaf2-cache-overflow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+23
−2
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1399,6 +1399,24 @@ flags : fpu mmx sse sse2 pni ssse3 sse4_1 sse4_2 | |
| } | ||
|
|
||
| // https://www.felixcloutier.com/x86/cpuid#example-3-1--example-of-cache-and-tlb-interpretation | ||
| // Regression test: a CPUID leaf 2 advertising the maximum number of cache/TLB | ||
| // descriptors must not overflow CacheInfo::levels. | ||
| TEST_F(CpuidX86Test, Leaf2_TooManyDescriptors_DoesNotOverflow) { | ||
| cpu().SetLeaves({ | ||
| {{0x00000000, 0}, Leaf{0x00000002, 0x756E6547, 0x6C65746E, 0x49656E69}}, | ||
| {{0x00000001, 0}, Leaf{0x00000F0A, 0x00010808, 0x00000000, 0x3FEBFBFF}}, | ||
| // Leaf 2 encodes one descriptor per byte across its four registers (16 | ||
| // bytes total). AL, the low byte of EAX, is the ignored count byte, so | ||
| // these all-0x01 registers forge 15 non-zero descriptors -- more than the | ||
| // old 10-entry CacheInfo::levels array and exactly filling the new 16. | ||
| {{0x00000002, 0}, Leaf{0x01010101, 0x01010101, 0x01010101, 0x01010101}}, | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add a comment below to indicate that we're forging 16 descriptors (one per byte). AL being discarded. so 15 descriptors. |
||
| }); | ||
|
|
||
| const auto info = GetX86CacheInfo(); | ||
| // All 15 descriptors are recorded, saturating the resized levels array. | ||
| EXPECT_EQ(info.size, 15); | ||
| } | ||
|
|
||
| TEST_F(CpuidX86Test, P4_CacheInfo) { | ||
| cpu().SetLeaves({ | ||
| {{0x00000000, 0}, Leaf{0x00000002, 0x756E6547, 0x6C65746E, 0x49656E69}}, | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should stay next to its original test.