Repository navigation
Retry rustfmt with a larger max_width on bailed-out items. - #2707
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_1009318745
branch
from
October 29, 2026 01:35
fb28fb0 to
abe436d
Compare
When a generated struct field type, trait header, or function signature exceeds `rustfmt`'s default 100-column `max_width` on an unbreakable path, `rustfmt` abandons formatting the enclosing item or function header. In `rs_bindings_from_cc` output, that leaves whole structs, `impl` blocks, or function headers collapsed onto a single line and skips `normalize_doc_attributes` on their `#[doc = "..."]` attributes, which also shifts post-formatting provenance comment counts for subsequent items.
Filter the first-pass output for lines exhibiting unformatted `tokens_to_string` patterns (extending function headers ending in `{` to their matching closing `}`) and run a targeted second pass with `--unstable-features --file-lines` and `max_width=10000`, while pinning sub-expression width heuristics (`fn_call_width`, `struct_lit_width`, `chain_width`, etc.) to their defaults so `rustfmt` skips sibling items via AST span intersection and inner calls still wrap normally.
PiperOrigin-RevId: 1009318745
copybara-service
Bot
force-pushed
the
test_1009318745
branch
from
October 29, 2026 03:06
abe436d to
837a84d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retry rustfmt with a larger max_width on bailed-out items.
When a generated struct field type, trait header, or function signature exceeds
rustfmt's default 100-columnmax_widthon an unbreakable path,rustfmtabandons formatting the enclosing item or function header. Inrs_bindings_from_ccoutput, that leaves whole structs,implblocks, or function headers collapsed onto a single line and skipsnormalize_doc_attributeson their#[doc = "..."]attributes, which also shifts post-formatting provenance comment counts for subsequent items.Filter the first-pass output for lines exhibiting unformatted
tokens_to_stringpatterns (extending function headers ending in{to their matching closing}) and run a targeted second pass with--unstable-features --file-linesandmax_width=10000, while pinning sub-expression width heuristics (fn_call_width,struct_lit_width,chain_width, etc.) to their defaults sorustfmtskips sibling items via AST span intersection and inner calls still wrap normally.