Repository navigation
Add the macro_constants Crubit feature - #2708
Merged
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
No behavior change: nothing checks the feature yet. Add a `macro_constants` feature, and an aspect hint to enable it. An upcoming change will use it to generate Rust constants for object-like C++ macros that expand to simple constant expressions, such as `#define FOO 4`. Like most opt-in features, it is also enabled by `all`, i.e. by the `experimental` aspect hint. PiperOrigin-RevId: 1009883886
copybara-service
Bot
force-pushed
the
test_1009283755
branch
from
October 29, 2026 19:37
56ac9bf to
9bba499
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
macro_constantsCrubit featureNo behavior change: nothing checks the feature yet.
Add a
macro_constantsfeature, and an aspect hint to enable it. Anupcoming change will use it to generate Rust constants for object-like
C++ macros that expand to simple constant expressions, such as
#define FOO 4. Like most opt-in features, it is also enabled byall,i.e. by the
experimentalaspect hint.