Repository navigation
Extract Importer::GetOwningTargetOfLocation - #2709
Merged
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_1009283754
branch
from
October 29, 2026 02:02
a3099dc to
ade8e9e
Compare
No behavior change. `GetOwningTarget` finds the target that owns a declaration from the declaration's location. Move that logic into a helper that takes a `SourceLocation`, since an upcoming change needs the owning targets of macro definitions, which aren't declarations. PiperOrigin-RevId: 1009850737
copybara-service
Bot
force-pushed
the
test_1009283754
branch
from
October 29, 2026 18:52
ade8e9e to
3425a5e
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract
Importer::GetOwningTargetOfLocationNo behavior change.
GetOwningTargetfinds the target that owns a declaration from thedeclaration's location. Move that logic into a helper that takes a
SourceLocation, since an upcoming change needs the owning targets ofmacro definitions, which aren't declarations.