Repository navigation
Fix unsupported subevents in PLD Poisson accounting - #558
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_1008357506
branch
from
October 28, 2026 19:02
124f9d7 to
bb6dac0
Compare
…events PiperOrigin-RevId: 1009097051
copybara-service
Bot
force-pushed
the
test_1008357506
branch
from
October 28, 2026 19:29
bb6dac0 to
f40a015
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix unsupported subevents in PLD Poisson accounting
Propagate the inner CompositionErrorDetails from the generic Poisson branch. Previously, PLDAccountant.supports() and compose() could accept unsupported nested events, including the example in #492 that reports epsilon zero. Returning the original error lets composition preflight reject the event before changing the parent ledger or accounting state, while preserving the offending subevent and diagnostic.
Fixes #492.
Validation:
24 parameterized regressions cover unsupported events and neighboring-relation mismatches, nested sampling/composition, and empty or prepopulated accountants. They fail on the unchanged source and pass with the repair; rejection preserves ledger, epsilon and delta.
377 tests pass across the PLD accountant, RDP accountant, event, event-builder and mechanism-calibration modules, including those 24 regressions. Supported Gaussian, Laplace and generic sampled-event controls retain their results.
Separate local public-API and pinned consumer-source comparisons preserve supported baseline/fixed results. These are bounded integration checks, not full training or application tests.
The reported regression is on unpublished main; released dp-accounting==0.6.0 already rejects the original example.
Closes #545
FUTURE_COPYBARA_INTEGRATE_REVIEW=#545 from autoCAT6:fix-pld-poisson-unsupported-subevents 38f7412