Improve performance of the map for large surveys - #3870
Open
andreia-ferreira wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3866
The performance of large surveys while in the home screen map was bad and could lead to OOM crashes. This was because every LOI outline was handed to the google maps sdk as soon as the survey loaded, just marked as invisible.
This PR changes that so clusterable items are added to the cluster manager but not to the map. Their outlines are created only when the clusterer decides to draw them individually, and released again once they're absorbed back into a cluster.
Before:
screen-20260804-235913.mp4
After:
screen-20260804-235515.mp4
@shobhitagarwal1612 PTAL?