Fix LegacyProtoTypeAdapterFactoryTest bitfield regex pattern. - #3083
Merged
Merged
Conversation
This will allow the test to pass even after some upcoming changes to the internal representation of Java protos.
Marcono1234
reviewed
Aug 6, 2026
| json.keySet().stream() | ||
| .filter(key -> pattern.matcher(key).find()) | ||
| .collect(toImmutableList()); | ||
| json.keySet().removeAll(keysToRemove); |
Contributor
There was a problem hiding this comment.
Not directly related, but instead of collecting the keys in keysToRemove and then doing keySet().removeAll(keysToRemove), would it be possible to directly do keySet().removeIf(...)?
Member
Author
There was a problem hiding this comment.
Yes, I think so. Obviously if we can do streams we can do removeIf. Feel free to add that change in here, or we can make a separate PR.
Member
Author
There was a problem hiding this comment.
Oh I got confused, I'm the one who could make this change. I think I'll defer it, though.
Member
|
(apologies for never getting around to providing the requested review on this, especially given how trivial it was) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow the test to pass even after some upcoming changes to the internal representation of Java protos.
This is internal cl/958647397.