Preserve linear_transform in Lattigo backend - #3315
Merged
Merged
Conversation
Collaborator
|
Rebased over #3313. The new changes are the secret-to-ckks and scheme-to-backend conversion passes, as well as the e2e tests and enabling it in the lattigo config. Interestingly: openfhe's linear_transform op is not part of their public API (and it only supports dense mode anyway, so it's less useful) so that backend is not enabled. |
mdgrs
reviewed
Aug 7, 2026
mdgrs
left a comment
mdgrs
left a comment
Collaborator
There was a problem hiding this comment.
I mostly live in the CKKS world, but this has broken a BGV test:
tests/Examples/common/cmux.mlir:1:1
copybara-service
Bot
force-pushed
the
test_960437546
branch
3 times, most recently
from
August 13, 2026 20:32
d55b94d to
8564c30
Compare
mdgrs
approved these changes
Aug 14, 2026
Collaborator
There was a problem hiding this comment.
There seems to be a several places where a soft error (notifyMatchFailure) is used where I think hard emitOpError would be more appropriate/ give users clearer feedback. I annotated a few in LWEToLattigo's conversion pattern, but I think it also applies to the other patterns.
copybara-service
Bot
force-pushed
the
test_960437546
branch
5 times, most recently
from
September 2, 2026 22:47
9542005 to
76d2c28
Compare
This change: - Implements the LWE-to-Lattigo lowering pattern for kernel.linear_transform to lattigo.ckks.linear_transform. - Enables has_kernel_linear_transform = 1 in Lattigo target config. - Fixes the Lattigo emitter to dynamically convert float32 diagonals to float64 in Go. - Resolves LevelQ and Scale matching issues in the emitter using dynamic ciphertext level instead of compile-time constants. - Aligns encoding slots with actual slot counts for CKKS bootstrapping. After this change, the e2e lattigo tests using linalg.matvec lower to use the linear_transform op. Still TODO is lowering a conv operator to an intermediate matvec op so it can be preserved as a linear_transform op, which is a bit of a larger change because it requires extracting the lowering for conv ops to occur before layout-propagation, and hard-coding the layout choice. PiperOrigin-RevId: 975385318
copybara-service
Bot
force-pushed
the
test_960437546
branch
from
September 2, 2026 23:16
76d2c28 to
cefe870
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve linear_transform in Lattigo backend
This change:
After this change, the e2e lattigo tests using linalg.matvec lower to use the linear_transform op.
Still TODO is lowering a conv operator to an intermediate matvec op so it can be preserved as a linear_transform op, which is a bit of a larger change because it requires extracting the lowering for conv ops to occur before layout-propagation, and hard-coding the layout choice.