Skip to content

Fix chained kwarg scoping after positional args#682

Closed
yoshibase wants to merge 1 commit into
google:masterfrom
yoshibase:fix/issue-379
Closed

Fix chained kwarg scoping after positional args#682
yoshibase wants to merge 1 commit into
google:masterfrom
yoshibase:fix/issue-379

Conversation

@yoshibase

Copy link
Copy Markdown

Summary

Fixes #379

Stop parsing keyword flags for the current command once a positional argument is encountered, so chained commands receive their own flags.

Test plan

  • python3 -m unittest fire.fire_test.FireTest.testChainedKwargsWithSameParameterName

Made with Cursor

Fixes google#379

Co-authored-by: Cursor <cursoragent@cursor.com>
@google-cla

google-cla Bot commented Jul 13, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@yoshibase

Copy link
Copy Markdown
Author

Pausing this PR for now: the cla/google check requires signing Google's CLA, and our contributor policy currently excludes repositories that require CLA signing. The fix remains prepared locally and can be resubmitted once CLA signing is feasible. Thank you for understanding.

@yoshibase yoshibase closed this Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mis-assigned keyword arguments when two function parameters have the same name

1 participant