Repository navigation
Fix oversized reads in EncapsulatedSession::InnerStream::Read. - #157
Open
neeraj1235476 wants to merge 1 commit into
Open
neeraj1235476 wants to merge 1 commit into
neeraj1235476 wants to merge 1 commit into
Conversation
Read() reported output.size() as bytes_read even when fewer bytes were buffered on the stream, so a caller reading into a fixed-size buffer would treat the uninitialized tail of its buffer as data received from the peer. The over-sized SkipBytes() call also hit QUICHE_BUG WT_H2_SkipBytes_toomuch and dropped the FIN signal. Count the bytes actually copied, skip only those, and return that count.
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EncapsulatedSession::InnerStream::Read(absl::Span<char>)reportsoutput.size()asbytes_readeven when the stream has fewer bytes buffered, and then skips that many bytes:The
webtransport::Streamcontract allows reading into a buffer larger thanReadableBytes()(the QUIC-backedWebTransportStreamAdapterhandles that case correctly), so a caller using a fixed-size buffer gets back abytes_readlarger than what was written and processes the uninitialized tail of its buffer as data received from the peer. The FIN is also lost in that case, sinceSkipBytes()bails out on the bug check before consuming it.Count the bytes actually copied and skip only those. The new
ReadIntoOversizedBuffertest covers both thebytes_readvalue and FIN delivery; it fails before this change and passes after.This fix was found and prepared with AI assistance and reviewed by me before submitting.