[neeraj1235476]

AddressSanitizer, release byte of a URI path/query to the exported validators:

header_properties.cc:245: runtime error: global-buffer-overflow
READ of size 1 ... 61 bytes before global variable 'invalidCharTable' (size 256)

HasInvalidPathChar and HasInvalidQueryChar loop over the value with a signed char and index a 256-entry std::array with it directly. Any byte >= 0x80 is negative, so the lookup reads before the table. The sibling validators in this file (IsValidToken, IsValidChunkExtension) already static_cast<uint8_t> before indexing; these two were missed. Iterating as uint8_t matches them and leaves results unchanged for valid ASCII input.

Triggered by any request-target byte >= 0x80 reaching these validators, e.g. a percent-unescaped UTF-8 path.

Regression cases covering high-bit bytes are added to header_properties_test.cc.

[gemini-code-assist]

Code Review

This pull request addresses potential out-of-bounds indexing issues in HasInvalidPathChar and HasInvalidQueryChar by ensuring characters with values >= 0x80 are safely processed, and adds corresponding test cases. The review feedback suggests avoiding implicit conversion warnings (such as -Wsign-conversion) in the range-based loops by iterating over const char and explicitly casting to uint8_t when indexing the lookup tables, which also aligns with other validators in the codebase.

[gemini-code-assist]

Implicitly converting char to uint8_t in the range-based for loop can trigger compiler warnings (such as -Wsign-conversion or -Wconversion) in strict build environments. To prevent this and maintain consistency with other validators in this file (like IsValidToken and IsValidChunkExtension), it is better to iterate over const char c and perform an explicit static_cast<uint8_t>(c) when indexing the lookup table.

Suggested change

	for (const uint8_t c : value) {
	if (invalidCharTable[c]) {
	for (const char c : value) {
	if (invalidCharTable[static_cast<uint8_t>(c)]) {

[gemini-code-assist]

Implicitly converting char to uint8_t in the range-based for loop can trigger compiler warnings (such as -Wsign-conversion or -Wconversion) in strict build environments. To prevent this and maintain consistency with other validators in this file (like IsValidToken and IsValidChunkExtension), it is better to iterate over const char c and perform an explicit static_cast<uint8_t>(c) when indexing the lookup table.

Suggested change

	for (const uint8_t c : value) {
	if (invalidCharTable[c]) {
	for (const char c : value) {
	if (invalidCharTable[static_cast<uint8_t>(c)]) {