Repository navigation
lzma_rust2 binding: keep the stream usable after LZMA_MEMLIMIT_ERROR - #228
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
liblzma treats `LZMA_MEMLIMIT_ERROR` as non-fatal: the stream stays usable and the next `lzma_code` call runs the limit check again from the same point in the input. The binding latched the stream after any error and answered `LZMA_PROG_ERROR` from then on. `lzma_code` now leaves the stream usable on `LZMA_MEMLIMIT_ERROR` only; a genuine allocation failure (`LZMA_MEM_ERROR`) and all other errors still fail the stream, as in liblzma. The consumed and produced counts of the failing call are recovered from the crate's counters, as already done for a truncated input, so `next_in` moves past the header the decoder has already taken and the caller does not feed it twice on the retry. PiperOrigin-RevId: 1008872199
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lzma_rust2 binding: keep the stream usable after LZMA_MEMLIMIT_ERROR
liblzma treats
LZMA_MEMLIMIT_ERRORas non-fatal: the stream stays usable and the nextlzma_codecall runs the limit check again from the same point in the input. The bindinglatched the stream after any error and answered
LZMA_PROG_ERRORfrom then on.lzma_codenow leaves the stream usable onLZMA_MEMLIMIT_ERRORonly; a genuine allocationfailure (
LZMA_MEM_ERROR) and all other errors still fail the stream, as in liblzma. Theconsumed and produced counts of the failing call are recovered from the crate's counters, as
already done for a truncated input, so
next_inmoves past the header the decoder has alreadytaken and the caller does not feed it twice on the retry.