fix: lock clock sequence in NewV6WithTime#219
Open
vsaraikin wants to merge 1 commit into
Open
Conversation
NewV6WithTime called getTime directly, bypassing timeMu, while every other caller (GetTime, used by NewV6/NewUUID) holds it. getTime reads and mutates the shared lasttime/clockSeq state, so concurrent NewV6WithTime calls raced and produced duplicate UUIDs. Take timeMu around getTime.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
NewV6WithTimegenerates duplicate UUIDs under concurrency, and has a data race on the shared clock-sequence state.getTimereads and mutates the package globalslasttimeandclockSeq(it bumpsclockSeqwhenever time hasn't advanced, which is what keeps same-timestamp UUIDs unique). That state is guarded bytimeMu:GetTime— used byNewV6()andNewUUID()— takes the lock before callinggetTime.NewV6WithTime(added in #172) is the only path that callsgetTimedirectly, without the lock.So concurrent
NewV6WithTimecallers read the sameclockSeq/lasttimeunsynchronized, producing identical UUIDs, and also race withNewV6()/NewUUID(), corrupting their uniqueness state.Fix
Take
timeMuaround thegetTimecall, matchingGetTime:Testing
Added
TestNewV6WithTimeConcurrentUnique: 8 goroutines generate 2000 V6 UUIDs each from the same fixed timestamp (16000 < 16384 clock-sequence values, so all must be unique). On the current code it fails deterministically (hundreds of duplicates) and-racereports the data race onlasttime/clockSeq; with the fix it passes cleanly. The full suite passes under-race, andgofmt -sis clean.