Skip to content

docs: Fix a couple of links in Markdown docs - #553

Merged
amanda-tarafa merged 4 commits into
googleapis:mainfrom
sampart:markdown-link-fixes
Oct 14, 2026
Merged

amanda-tarafa merged 4 commits into
googleapis:mainfrom
sampart:markdown-link-fixes

Conversation

@sampart

@sampart sampart commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

This PR makes two markdown fixes:

  1. Fix contributing link in README. This appears to have been removed in error in feat: Add ADC support for impersonated credentials #547 and means that at present (prior to my fix) the README section looks like this:

Contributing

See [CONTRIBUTING][contributing].

  1. Fix Contributing guide link to CHANGELOG

@sampart
sampart requested a review from a team December 3, 2025 12:57
@sampart sampart changed the title Fix a couple of links in Markdown docs docs: Fix a couple of links in Markdown docs Dec 3, 2025
Comment thread .github/CONTRIBUTING.md Resolved
@amanda-tarafa
amanda-tarafa requested a review from quartzmo October 9, 2026 23:12
@amanda-tarafa amanda-tarafa added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 9, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 9, 2026
@amanda-tarafa

Copy link
Copy Markdown

Also, can you rebase on main and push again, the tests are failing possibly because of the old branch.

@sampart
sampart force-pushed the markdown-link-fixes branch from 815e185 to 701dddc Compare October 13, 2026 13:23
@sampart
sampart requested a review from a team as a code owner October 13, 2026 13:23
@sampart

sampart commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

Also, can you rebase on main and push again, the tests are failing possibly because of the old branch.

Thanks @amanda-tarafa. Done 👍

@sampart
sampart requested a review from amanda-tarafa October 13, 2026 13:24
Comment thread README.md Outdated
about the client or APIs on [StackOverflow](http://stackoverflow.com).

[application default credentials]: https://cloud.google.com/docs/authentication/provide-credentials-adc
[contributing]: ./.github/CONTRIBUTING.md

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is failing when Yard compiles doc, because the README.md ends up in a doc folder, so the relative path ends up relative to the doc folder as well. We need the absolute path here https://github.com/googleapis/google-auth-library-ruby/blob/main/.github/CONTRIBUTING.md.

(We could also move CONTRIBUTING to the repo root but that may have some other consequences, so let's use the absolute path instead)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 84c19ee 👍

@sampart
sampart requested a review from amanda-tarafa October 14, 2026 11:00

@amanda-tarafa amanda-tarafa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@quartzmo quartzmo closed this Oct 14, 2026
@quartzmo quartzmo reopened this Oct 14, 2026
@amanda-tarafa
amanda-tarafa merged commit 51fe67a into googleapis:main Oct 14, 2026
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants