Repository navigation
fix(external_account): convert executable timeout_millis to seconds for Timeout.timeout - #604
Draft
torreypayne wants to merge 1 commit into
Draft
torreypayne wants to merge 1 commit into
torreypayne wants to merge 1 commit into
Conversation
…or Timeout.timeout External-account executable configuration defines timeout_millis in milliseconds, but PluggableAuthCredentials#subprocess_with_timeout passes the value to Timeout.timeout, which expects seconds. Convert @credential_source_executable_timeout_millis to seconds (timeout_millis / 1000.0) when invoking subprocess_with_timeout, and add specs verifying the converted timeout duration. Fixes #595
torreypayne
force-pushed
the
fix/pluggable-timeout-millis
branch
from
October 21, 2026 17:31
440bc15 to
704442d
Compare
torreypayne
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PluggableAuthCredentials passed timeout_millis directly to Timeout.timeout, which expects seconds, causing a configured 30000 ms timeout to wait 30,000 seconds.
This converts @credential_source_executable_timeout_millis to seconds (timeout_millis / 1000.0) when invoking subprocess_with_timeout, and adds unit specs verifying that Timeout.timeout receives the converted seconds value for both configured and default timeouts.
Thanks to @OskarEichler for the report and proposed correction.
Fixes #595