Skip to content

fix(external_account): strip -fips suffix from AWS service name in SigV4 signer #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
macastelaz wants to merge 1 commit into
base: main
Choose a base branch
from
+33 −1
Draft

fix(external_account): strip -fips suffix from AWS service name in SigV4 signer #608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/googleauth/external_account/aws_credentials.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ def generate_signed_request aws_credentials, original_request
principal: "aws"
)
end
service_name = uri.host.split(".").first
service_name = uri.host.split(".").first.delete_suffix("-fips")

datetime = Time.now.utc.strftime "%Y%m%dT%H%M%SZ"
date = datetime[0, 8]
Expand Down
32 changes: 32 additions & 0 deletions spec/googleauth/external_account/aws_credentials_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,4 +484,36 @@ def make_auth_stubs opts
expect { credentials.fetch_access_token! }.to raise_error(/Invalid AWS service URL/)
end
end

describe Google::Auth::ExternalAccount::AwsRequestSigner do
it 'strips -fips suffix from service name when signing FIPS STS requests' do
allow(Time).to receive(:now).and_return(Time.strptime('2020-08-11T06:55:22Z', '%Y-%m-%dT%H:%M:%SZ'))
request_signer = Google::Auth::ExternalAccount::AwsRequestSigner.new('us-east-2')
access_key_id = 'ASIARD4OQDT6A77FR3CL'
secret_access_key = 'Y8AfSaucF37G4PpvfguKZ3/' + 'l7Id4uocLXxX0+VTx'
session_token = 'test_session_token'
original_request = {
method: 'POST',
url: 'https://sts-fips.us-east-2.amazonaws.com?Action=GetCallerIdentity&Version=2011-06-15'
}
actual = request_signer.generate_signed_request(
{
access_key_id: access_key_id,
secret_access_key: secret_access_key,
session_token: session_token
},
original_request
)
expect(actual).to eq({
url: 'https://sts-fips.us-east-2.amazonaws.com?Action=GetCallerIdentity&Version=2011-06-15',
method: 'POST',
headers: {
'Authorization' => "AWS4-HMAC-SHA256 Credential=#{access_key_id}/20200811/us-east-2/sts/aws4_request, SignedHeaders=host;x-amz-date;x-amz-security-token, Signature=4b549b7c3a615721e18adf21235665b1ef16d19b3db471ab6037a2f40f9048af",
'host' => 'sts-fips.us-east-2.amazonaws.com',
'x-amz-date' => '20200811T065522Z',
'x-amz-security-token' => session_token
}
})
end
end
end
Loading