Skip to content

ci: Do not run the autogenerated GAPICs unit tests #13495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lqiu96 wants to merge 3 commits into
base: main
Choose a base branch
from
+11 −0
Draft

ci: Do not run the autogenerated GAPICs unit tests #13495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
335f5f8
ci: disable generated GAPIC unit tests by default
lqiu96 Jun 16, 2026
e67b010
chore: Update regex to remove the generated tests only
lqiu96 Jun 16, 2026
4cb7f32
chore: Add small exclusion for BQstorage
lqiu96 Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions google-cloud-jar-parent/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
<properties>
<skipUnitTests>false</skipUnitTests>
<ignoreNonCompile>true</ignoreNonCompile><!-- maven-dependency-plugin:analyze to skip test scope dependencies -->
<surefire.excludes>**/v*/*ClientTest.java,**/v*/*ClientHttpJsonTest.java</surefire.excludes>
</properties>

<dependencyManagement>
Expand Down Expand Up @@ -219,6 +220,15 @@
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<skip>${skipUnitTests}</skip>
<!-- Exclude generated client unit tests directly under versioned packages (e.g., v1, v2)
to save CI execution time. We use the narrow 'v*/*' pattern (single asterisk)
instead of 'v*/**' to ensure we do not exclude manually written unit tests
which live in sub-packages (e.g., v1/client/ or v2/internal/api/).
If a module has customized subclass tests under a versioned package,
override <surefire.excludes/> to empty in its local pom.xml (e.g., google-cloud-bigquerystorage). -->
<excludes>
<exclude>${surefire.excludes}</exclude>
</excludes>
Comment on lines +229 to +231

@gemini-code-assist gemini-code-assist Bot Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

In Maven, when a plugin parameter is of type List (like excludes in maven-surefire-plugin), nesting a comma-separated property inside an <exclude> tag prevents Maven from splitting the string. It treats the entire comma-separated value as a single literal pattern containing a comma, which will fail to match any files and render the exclusion ineffective.

To allow Maven to correctly split the comma-separated property ${surefire.excludes} into individual list elements, pass the property directly to the <excludes> element.

          <excludes>${surefire.excludes}</excludes>

</configuration>
</plugin>
<plugin>
Expand Down
1 change: 1 addition & 0 deletions java-bigquerystorage/google-cloud-bigquerystorage/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
</parent>
<properties>
<site.installationModule>google-cloud-bigquerystorage</site.installationModule>
<surefire.excludes></surefire.excludes>
</properties>
<dependencyManagement>
<dependencies>
Expand Down
Loading