Repository navigation
chore(bigtable): update pytest-asyncio - #18922
Merged
mutianf merged 2 commits intoOct 30, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request unpins the pytest-asyncio dependency, removes a custom event_loop fixture, and introduces a pytest.ini configuration to set default loop scopes. The review feedback points out that asyncio_default_test_loop_scope is an invalid option that will cause pytest to fail on startup. Additionally, the reviewer recommends specifying a minimum version of pytest-asyncio>=0.24.0 in both the noxfile.py and the integration configuration to support the asyncio_default_fixture_loop_scope option.
mutianf
approved these changes
Oct 30, 2026
mutianf
deleted the
google-cloud-python-internal_bigtable_pytest-asyncio-upgrade
branch
October 30, 2026 02:38
daniel-sanche
added a commit
that referenced
this pull request
Oct 30, 2026
Bigtable had pytest-asyncio pinned to an old version, which was incompatible with newer pytest versions. This PR unpins it, and changes how the event loop is set up to match new expectations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bigtable had pytest-asyncio pinned to an old version, which was incompatible with newer pytest versions. This PR unpins it, and changes how the event loop is set up to match new expectations