Repository navigation
feat(storage): add enterprise storage class constants - #18952
Open
chandra-siri wants to merge 2 commits into
Open
chandra-siri wants to merge 2 commits into
chandra-siri wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces three new enterprise storage class constants (STANDARD_ENTERPRISE, STANDARD_FLEXBACKUP_ENTERPRISE, and LR_STANDARD_ENTERPRISE) to the Google Cloud Storage Python client. It also adds comprehensive unit and system tests to verify bucket creation, blob storage class updates, and property setters using these new constants. I have no feedback to provide.
chandra-siri
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds public storage class constants for Cloud Storage Enterprise Storage Classes (
STANDARD_ENTERPRISE,STANDARD_FLEXBACKUP_ENTERPRISE, andLR_STANDARD_ENTERPRISE) ingoogle/cloud/storage/constants.py:google/cloud/storage/constants.py:STANDARD_ENTERPRISE_STORAGE_CLASS = "STANDARD_ENTERPRISE"STANDARD_FLEXBACKUP_ENTERPRISE_STORAGE_CLASS = "STANDARD_FLEXBACKUP_ENTERPRISE"LR_STANDARD_ENTERPRISE_STORAGE_CLASS = "LR_STANDARD_ENTERPRISE"tests/unit/test_bucket.py,tests/unit/test_blob.py) and system tests (tests/system/test_bucket.py,tests/system/test_blob.py) using@pytest.mark.parametrizeto verify bucket creation and blob storage class updates with the new Enterprise storage class constants.Split from #18949 (Part 2 of 2:
constants.pyadditions).