Repository navigation
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the transport configuration for the Redis integration test from 'grpc+rest' to 'rest' only, resulting in the removal of gRPC-related code, async clients, async pagers, and async code samples from the generated golden files. Feedback on the changes highlights that although the async client is no longer exported, the 'async_client.py' file is still being generated as dead code; the generator should be updated to completely omit this file when the configured transport does not support or export an async client.
I am having trouble creating individual review comments. Click here to see my feedback.
packages/gapic-generator/tests/integration/goldens/redis/google/cloud/redis_v1/services/cloud_redis/async_client.py (306-332)
With transport = "rest", CloudRedisAsyncClient is no longer exported in __init__.py, and all async code samples have been removed. However, the async_client.py file itself is still being generated. This results in dead code in the generated library. The generator should be updated to completely omit generating async_client.py when the configured transport (like REST-only) does not support or export an async client.
References
- Do not suggest manual code modifications, optimizations, or style fixes for generated files, as any changes should be implemented in the generator or templates to prevent them from being overwritten.
59517ee to
418976f
Compare
418976f to
3c21a6f
Compare
|
The failing presubmit |
This PR updates the
showcase_unitnox session to include a REST only configuration.