Skip to content

ci: add REST only config to showcase unit nox session - #18957

Open
parthea wants to merge 2 commits into
mainfrom
rest-only-api-goldens
Open

parthea wants to merge 2 commits into
mainfrom
rest-only-api-goldens

Conversation

@parthea

@parthea parthea commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

This PR updates the showcase_unit nox session to include a REST only configuration.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the transport configuration for the Redis integration test from 'grpc+rest' to 'rest' only, resulting in the removal of gRPC-related code, async clients, async pagers, and async code samples from the generated golden files. Feedback on the changes highlights that although the async client is no longer exported, the 'async_client.py' file is still being generated as dead code; the generator should be updated to completely omit this file when the configured transport does not support or export an async client.

I am having trouble creating individual review comments. Click here to see my feedback.

packages/gapic-generator/tests/integration/goldens/redis/google/cloud/redis_v1/services/cloud_redis/async_client.py (306-332)

medium

With transport = "rest", CloudRedisAsyncClient is no longer exported in __init__.py, and all async code samples have been removed. However, the async_client.py file itself is still being generated. This results in dead code in the generated library. The generator should be updated to completely omit generating async_client.py when the configured transport (like REST-only) does not support or export an async client.

References
  1. Do not suggest manual code modifications, optimizations, or style fixes for generated files, as any changes should be implemented in the generator or templates to prevent them from being overwritten.

@parthea
parthea force-pushed the rest-only-api-goldens branch from 59517ee to 418976f Compare November 2, 2026 18:08
@parthea
parthea force-pushed the rest-only-api-goldens branch from 418976f to 3c21a6f Compare November 2, 2026 18:20
@parthea parthea changed the title ci: add REST only API to goldens ci: add REST only config to showcase unit nox session Nov 2, 2026
@parthea parthea closed this Nov 2, 2026
@parthea parthea reopened this Nov 2, 2026
@parthea parthea closed this Nov 2, 2026
@parthea parthea reopened this Nov 2, 2026
@parthea

parthea commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

The failing presubmit GitHub Actions Scan will be fixed via #18962

@parthea
parthea marked this pull request as ready for review November 3, 2026 02:56
@parthea
parthea requested a review from a team as a code owner November 3, 2026 02:56

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant